Fix/form labels accessibility#975
Open
Benedict315 wants to merge 11 commits into
Open
Conversation
ogazboiz
requested changes
Jul 1, 2026
ogazboiz
left a comment
ogazboiz
left a comment
Contributor
There was a problem hiding this comment.
the a11y part is real and good, dashboard-view.tsx gets proper htmlFor/id pairing on the template name, recipient, token, amount, dates, cadence and note inputs. but this pr is effectively #972 plus that a11y work: it carries the same 410 deprecated-handlers, the same ci.yml:98 @vitest/coverage-v8 install removal (which risks re-breaking the coverage job), and the same Dockerfile/worker newline churn. two asks:
- drop the ci.yml coverage-v8 install removal (same regression risk i flagged on #972) and the Dockerfile/worker churn.
- this and #972 overlap, pick one lane, if you want the a11y work, take this one (stripped) and close #972 as redundant.
the a11y changes are mergeable, it's the bundled ci change that blocks it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Related Issues
Closes #
Changes Made
Testing
Test Coverage
Test Steps
Breaking Changes
Breaking Changes:
Migration Guide:
Screenshots/Demo
Checklist
Additional Notes
closes #632